Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.envisage: 4.9.2 -> 5.0.0 #117719

Merged
merged 2 commits into from Mar 30, 2021
Merged

Conversation

rmcgibbo
Copy link
Contributor

Motivation for this change

#117696 (comment)
#117696 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 117719 at 54831621 run on x86_64-linux 1

2 packages skipped due to time constraints:
  • python38Packages.mayavi
  • python39Packages.mayavi
3 packages built successfully:
  • python38Packages.envisage
  • python39Packages.apptools
  • python39Packages.envisage
3 suggestions:
  • warning: unused-argument

    Unused argument: fetchpatch.
    Near pkgs/development/python-modules/envisage/default.nix:1:19:

      |
    1 | { lib, fetchPypi, fetchpatch, isPy27
      |                   ^
    
  • warning: unused-argument

    Unused argument: pythonOlder.
    Near pkgs/development/python-modules/apptools/default.nix:4:3:

      |
    4 | , pythonOlder, importlib-resources
      |   ^
    
  • warning: unused-argument

    Unused argument: python.
    Near pkgs/development/python-modules/envisage/default.nix:4:3:

      |
    4 | , python, ipykernel, ipython
      |   ^
    

@risicle
Copy link
Contributor

risicle commented Mar 27, 2021

ofborg's aarch64 failure looks like it timed out while running the scipy tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants