Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradm: 3.1-202012071814 -> 3.1-202102241600 #117722

Merged
merged 1 commit into from May 17, 2021

Conversation

rmcgibbo
Copy link
Contributor

Motivation for this change

Looks like a package got deleted from the internet, causing hydra to fail: https://hydra.nixos.org/job/nixpkgs/trunk/gradm.x86_64-linux

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 26, 2021

Result of nixpkgs-review pr 117722 at 99d81f4a run on x86_64-linux 1

1 package built successfully:
  • gradm
1 suggestion:
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/sbin/gradm_pam' doesn't match anything in file 'gradm_defs.h'
    Near pkgs/os-specific/linux/gradm/default.nix:45:0:

       |
    45 |     description = "grsecurity RBAC administration and policy analysis utility";
       | ^
    

Result of nixpkgs-review pr 117722 at 99d81f4a run on aarch64-linux 1

1 package failed to build:

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

@rmcgibbo
Copy link
Contributor Author

I do not understand what the cause of the aarch64-specific failure is.

@@ -5,11 +5,11 @@

stdenv.mkDerivation rec {
pname = "gradm";
version = "3.1-202012071814";
version = "3.1-202102241600";

src = fetchurl {
url = "http://grsecurity.net/stable/${pname}-${version}.tar.gz";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we throw this onto web.archive.org if that happens more often?

@dotlambda
Copy link
Member

I do not understand what the cause of the aarch64-specific failure is.

Me neither, but we should merge this anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants