Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use minimal git for fetching gems #117727

Merged
merged 1 commit into from Mar 27, 2021
Merged

Conversation

edude03
Copy link
Contributor

@edude03 edude03 commented Mar 26, 2021

Motivation for this change

Noticed that using buildRubyGem would pull in a second ruby interpreter due to using "full fat" git, which includes asciidoctor (which brings it's own ruby interpreter)

I patched this locally to see if it would fix the issue and at least in my testing it works just the same, with the benefit of smaller closure size (and faster builds if you don't have that git/asciidoc/ruby combo built already)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 26, 2021

Result of nixpkgs-review pr 117727 at ae4fac9f run on x86_64-linux 1

1 package skipped due to time constraints:
  • mastodon
2 packages built successfully:
  • anystyle-cli
  • metasploit

Result of nixpkgs-review pr 117727 at ae4fac9f run on aarch64-linux 1

2 packages built successfully:
  • anystyle-cli
  • metasploit

Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperSandro2000 SuperSandro2000 merged commit 5a9bce6 into NixOS:master Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants