Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alertmanager-irc-relay: init at 0.3.0 #117759

Merged
merged 1 commit into from Apr 12, 2021
Merged

alertmanager-irc-relay: init at 0.3.0 #117759

merged 1 commit into from Apr 12, 2021

Conversation

ymatsiuk
Copy link
Contributor

Motivation for this change

closes #117178

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit March 27, 2021 07:05
@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 27, 2021 •
edited

Result of nixpkgs-review pr 117759 at 036f61fc run on aarch64-linux 1

1 package built successfully:
  • alertmanager-irc-relay
1 suggestion:
  • warning: unused-argument

    Unused argument: stdenv.
    Near pkgs/servers/monitoring/alertmanager-irc-relay/default.nix:1:8:

      |
1 | { lib, stdenv, buildGoModule, fetchFromGitHub }:
  |        ^

Result of nixpkgs-review pr 117759 at 036f61fc run on x86_64-linux 1

1 package built successfully:
  • alertmanager-irc-relay
1 suggestion:
  • warning: unused-argument

    Unused argument: stdenv.
    Near pkgs/servers/monitoring/alertmanager-irc-relay/default.nix:1:8:

      |
1 | { lib, stdenv, buildGoModule, fetchFromGitHub }:
  |        ^

@ymatsiuk @SuperSandro2000
alertmanager-irc-relay: init at 0.3.0
1559745 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Signed-off-by: Yurii Matsiuk <ymatsiuk@users.noreply.github.com>
@ymatsiuk
Copy link
Contributor Author

ymatsiuk commented Apr 8, 2021

@SuperSandro2000 is there anything that blocks this from merging?

@SuperSandro2000 SuperSandro2000 merged commit e040eb5 into NixOS:master Apr 12, 2021
@ymatsiuk ymatsiuk deleted the 117178 branch May 3, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

alertmanager-irc-relay
3 participants
@ymatsiuk @r-rmcgibbo @SuperSandro2000