Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coordgenlibs: 1.4.2 -> 2.0.0 #117765

Merged
merged 1 commit into from Mar 27, 2021

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/schrodinger/coordgenlibs/releases.

meta.description for coordgenlibs is: "Schrodinger-developed 2D Coordinate Generation"

meta.homepage for coordgenlibs is: ""

meta.changelog for coordgenlibs is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
9 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
2 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
coordgenlibs
python38Packages.rdkit
python39Packages.rdkit
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/r37s70nihg4f6aad5nnvqrkm54asi3h2-coordgenlibs-2.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A coordgenlibs https://github.com/r-ryantm/nixpkgs/archive/f250e5b8987cbfc7ec3d58638e08eefa9f4b0a83.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/r37s70nihg4f6aad5nnvqrkm54asi3h2-coordgenlibs-2.0.0
ls -la /nix/store/r37s70nihg4f6aad5nnvqrkm54asi3h2-coordgenlibs-2.0.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

3 packages built:
  • coordgenlibs
  • python38Packages.rdkit
  • python39Packages.rdkit

Maintainer pings

cc @rmcgibbo for testing.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 117765 at f250e5b run on x86_64-linux 1

2 packages skipped due to time constraints:
  • python38Packages.rdkit
  • python39Packages.rdkit
1 package built successfully:
  • coordgenlibs

Copy link
Contributor

@rmcgibbo rmcgibbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built it + python38Packages.rdkit locally on x86_64-linux and tested generating some 2D structures in rdkit, which uses this library. Despite the major version bump, everything looks great.

Release notes are very minor: https://github.com/schrodinger/coordgenlibs/releases/tag/v2.0.0

@SuperSandro2000 SuperSandro2000 merged commit 389e767 into NixOS:master Mar 27, 2021
@r-ryantm r-ryantm deleted the auto-update/coordgenlibs branch March 27, 2021 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants