Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nvim whichkey setup.lua #117813

Merged
merged 2 commits into from Mar 29, 2021
Merged

Conversation

pinpox
Copy link
Member

@pinpox pinpox commented Mar 27, 2021

Motivation for this change

add vim plugin nvim-whichkey-setup-lua
https://github.com/AckslD/nvim-whichkey-setup.lua

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 27, 2021

Result of nixpkgs-review pr 117813 at b86afb8 run on x86_64-linux 1

1 package failed to build:
30 packages built successfully:
  • spacevim
  • vimPlugins.ale
  • vimPlugins.chadtree
  • vimPlugins.coc-lua
  • vimPlugins.dashboard-nvim
  • vimPlugins.denite-nvim
  • vimPlugins.gitsigns-nvim
  • vimPlugins.iosvkem
  • vimPlugins.lspsaga-nvim
  • vimPlugins.lualine-nvim
  • vimPlugins.neogit
  • vimPlugins.nvcode-color-schemes-vim
  • vimPlugins.nvim-bqf
  • vimPlugins.nvim-bufferline-lua
  • vimPlugins.nvim-jdtls
  • vimPlugins.nvim-lspconfig
  • vimPlugins.nvim-tree-lua
  • vimPlugins.nvim-treesitter
  • vimPlugins.nvim-whichkey-setup-lua
  • vimPlugins.registers-nvim
  • vimPlugins.tmux-complete-vim
  • vimPlugins.vim-airline
  • vimPlugins.vim-dispatch
  • vimPlugins.vim-fugitive
  • vimPlugins.vim-go
  • vimPlugins.vim-kitty-navigator
  • vimPlugins.vim-which-key
  • vimPlugins.vimtex
  • vimPlugins.vista-vim
  • vimPlugins.zephyr-nvim
2 suggestions:
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.


Result of nixpkgs-review pr 117813 at b86afb8 run on aarch64-linux 1

1 package failed to build:
1 package built successfully:
  • spacevim
2 suggestions:
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/misc/vim-plugins/build-vim-plugin.nix:28:14:

       |
    28 |       inherit unpackPhase configurePhase buildPhase addonInfo preInstall postInstall;
       |              ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.

@SuperSandro2000
Copy link
Member

@pinpox can you rebase the PR on master?

@pinpox
Copy link
Member Author

pinpox commented Mar 29, 2021

@SuperSandro2000 I hope I did that right, let me know if I messed up the rebase

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 117813 run on x86_64-linux 1

23 packages built:
  • spacevim
  • vimPlugins.chadtree
  • vimPlugins.dashboard-nvim
  • vimPlugins.denite-nvim
  • vimPlugins.gitsigns-nvim
  • vimPlugins.lspsaga-nvim
  • vimPlugins.neogit
  • vimPlugins.nvim-bqf
  • vimPlugins.nvim-bufferline-lua
  • vimPlugins.nvim-jdtls
  • vimPlugins.nvim-lspconfig
  • vimPlugins.nvim-tree-lua
  • vimPlugins.nvim-treesitter
  • vimPlugins.nvim-whichkey-setup-lua
  • vimPlugins.registers-nvim
  • vimPlugins.tmux-complete-vim
  • vimPlugins.vim-airline
  • vimPlugins.vim-dispatch
  • vimPlugins.vim-fugitive
  • vimPlugins.vim-go
  • vimPlugins.vim-kitty-navigator
  • vimPlugins.vim-which-key
  • vimPlugins.zephyr-nvim

@SuperSandro2000 SuperSandro2000 merged commit dd66fff into NixOS:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants