Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radarr: change sed separator in update script #117877

Merged
merged 1 commit into from Mar 28, 2021

Conversation

andreisergiu98
Copy link
Member

@andreisergiu98 andreisergiu98 commented Mar 28, 2021

Motivation for this change

I just realized that a base64 string can contain / characters and if we also use / as a separator for sed it will most certainly break at some point. So I replaced it with | and also added gnused package to the script just to be safe.

I am sorry I missed that.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

I am sorry I missed that.

It just an update script. Nothing game breaking.

@andreisergiu98 andreisergiu98 deleted the fix-radarr-script branch December 7, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants