Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coqPackages.odd-order: init at 1.12.0 #118028

Merged
merged 1 commit into from Mar 31, 2021
Merged

coqPackages.odd-order: init at 1.12.0 #118028

merged 1 commit into from Mar 31, 2021
+25 −0

Conversation

siraben
Copy link
Member

@siraben siraben commented Mar 30, 2021 •
edited

Motivation for this change

Add proof of the Fiet-Thompson odd-order theorem.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CohenCyril
Copy link
Contributor

@GrahamcOfBorg build coqPackages_8_11.odd-order coqPackages_8_12.odd-order coqPackages_8_13.odd-order

@CohenCyril
Copy link
Contributor

CohenCyril commented Mar 30, 2021 •
edited by vbgl

@GrahamcOfBorg build coqPackages_8_11.odd-order coqPackages_8_12.odd-order coqPackages_8_13.odd-order

@siraben
Copy link
Member Author

siraben commented Mar 30, 2021

Result of nixpkgs-review pr 118028 run on x86_64-darwin 1

1 package built:
  • coqPackages.odd-order

@siraben
Copy link
Member Author

siraben commented Mar 31, 2021

Result of nixpkgs-review pr 118028 run on x86_64-darwin 1

1 package built:
  • coqPackages.odd-order

@vbgl vbgl merged commit 80d5498 into NixOS:master Mar 31, 2021
@siraben siraben deleted the odd-order-init branch March 31, 2021 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl left review comments

@CohenCyril CohenCyril Awaiting requested review from CohenCyril

@jwiegley jwiegley Awaiting requested review from jwiegley

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siraben @CohenCyril @vbgl