Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moodle-dl: init at 2.1.2.5 #118087

Merged
merged 1 commit into from Mar 31, 2021
Merged

Conversation

kmein
Copy link
Member

@kmein kmein commented Mar 30, 2021

Motivation for this change

This package was missing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Lassulus
Copy link
Member

Result of nixpkgs-review pr 118087 1

1 package built:
  • moodle-dl

@r-rmcgibbo
Copy link

r-rmcgibbo commented Mar 30, 2021

Result of nixpkgs-review pr 118087 at eed576d3 run on x86_64-linux 1

1 package built successfully:
  • moodle-dl
3 suggestions:
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/tools/networking/moodle-dl/default.nix:27:0:

       |
    27 |     description = "A Moodle downloader that downloads course content fast from Moodle";
       | ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/tools/networking/moodle-dl/default.nix:11:15:

       |
    11 |   patches = [ ./readchar-version.patch ]; # nixpkgs doesn't have version 2.0.1, so we use 2.0.0
       |               ^
    
  • warning: unused-argument

    Unused argument: stdenv.
    Near pkgs/tools/networking/moodle-dl/default.nix:1:3:

      |
    1 | { stdenv, lib, python3Packages }:
      |   ^
    

Result of nixpkgs-review pr 118087 at 03450b9e run on aarch64-linux 1

1 package built successfully:
  • moodle-dl
1 suggestion:
  • warning: no-python-tests

    Test runner could not discover any test cases: ‘Ran 0 tests in 0.000s’
    Near pkgs/tools/networking/moodle-dl/default.nix:30:0:

       |
    30 |     description = "A Moodle downloader that downloads course content fast from Moodle";
       | ^
    

pkgs/tools/networking/moodle-dl/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/moodle-dl/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/moodle-dl/default.nix Outdated Show resolved Hide resolved
pkgs/tools/networking/moodle-dl/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 merged commit d544fdd into NixOS:master Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants