haxe: add 4.1 and 4.0 compiler versions #118112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 2 packages built successfully:
Result of 2 packages built successfully:
1 suggestion:
|
|
Sorry for the late response! Tested |
OPNA2608
requested changes
Apr 14, 2021
OPNA2608
approved these changes
Apr 14, 2021
10 tasks
Unfortunately there's no way to get Haxe 4.0 and 4.1 to work with extlib 1.7.8 (not even without the minimal install), so we need to package 1.7.7 again, at least until 1.7.9 (?) brings backwards compatibility packages, hopefully.
sternenseemann
force-pushed
the
haxe-4.1-4.0
branch
from
108cd8e
to
aa7cbd0
Compare
|
@ofborg build haxe_4_0 haxe_4_1 ocamlPackages.ocaml_extlib ocamlPackages.ocaml_extlib-1-7-7 |
sternenseemann
force-pushed
the
haxe-4.1-4.0
branch
from
aa7cbd0
to
cfc5998
Compare
sternenseemann
referenced
this pull request
Apr 19, 2021
Unfortunately there's no way to get Haxe 4.0 and 4.1 to work with extlib 1.7.8 (not even without the minimal install), so we need to package 1.7.7 again, at least until 1.7.9 (?) brings backwards compatibility packages, hopefully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #95638. cc @OPNA2608
Arguably the extlib 1.7.7 override is not ideal, but I don't really want to be stuck with it in
ocamlPackagesas long as we don't need it for anything else. The compatibility patch from 4.2 unfortunately doesn't even apply on 4.1.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)