Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
pass import needs magic to determine file types
the current python dependency used is
https://github.com/aliles/filemagic. This is very outdated and when
running the import plugin we get an error "AttributeError: module
'magic' has no attribute 'from_buffer'"
Pass import actually specifies this: https://github.com/file/file as the
required dependency. Using these python bindings fixes the error
pass-import relies on the PREFIX variable being set. Normally it is
available when the extension is called from pass because pass sources
the extension entry point script. Because of the way the extension gets
wrapped by nix we need to export PREFIX in the wrapper script.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)