Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drawio: 14.4.3 -> 14.5.1 #118165

Merged
merged 1 commit into from Mar 31, 2021
Merged

drawio: 14.4.3 -> 14.5.1 #118165

merged 1 commit into from Mar 31, 2021

Conversation

0xKDI
Copy link
Member

@0xKDI 0xKDI commented Mar 31, 2021

Motivation for this change

https://github.com/jgraph/drawio-desktop/releases/tag/v14.5.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@0xKDI 0xKDI requested a review from danieldk March 31, 2021 19:05
@SuperSandro2000
Copy link
Member

@ofborg eval

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 118165 at 6109cef run on x86_64-linux 1

1 package built successfully:
  • drawio
1 suggestion:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/graphics/drawio/default.nix:68:3:

       |
68 |   installPhase = ''
   |   ^

@SuperSandro2000 SuperSandro2000 merged commit 91936ab into NixOS:master Mar 31, 2021
@0xKDI 0xKDI deleted the drawio/update branch April 1, 2021 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@danieldk danieldk Awaiting requested review from danieldk

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0xKDI @SuperSandro2000 @r-rmcgibbo