sphinx_rtd_theme: 0.4.3 -> 0.5.1 #118180
sphinx_rtd_theme: 0.4.3 -> 0.5.1 #118180
Conversation
|
Result of 12 packages built successfully:
1 suggestion:
Result of 12 packages built successfully:
1 suggestion:
|
| }; | ||
|
|
||
| propagatedBuildInputs = [ sphinx ]; | ||
|
|
||
| checkInputs = [ readthedocs-sphinx-ext pytest ]; | ||
| CI=1; |
There was a problem hiding this comment.
Can we export this variable where it is required?
There was a problem hiding this comment.
I don't understand what you mean. It is exported for the build and required by the build. Are you saying you would prefer to patch the build script?
There was a problem hiding this comment.
No, it would be nicer if we did something like
preBuild = ''
export CI=1
'';|
|
||
| src = fetchPypi { | ||
| inherit pname version; | ||
| sha256 = "728607e34d60456d736cc7991fd236afb828b21b82f956c5ea75f94c8414040a"; | ||
| sha256 = "19c31qhfiqbm6y7mamglrc2mc7l6n4lasb8jry01lc67l3nqk9pd"; | ||
| }; | ||
|
|
||
| propagatedBuildInputs = [ sphinx ]; | ||
|
|
||
| checkInputs = [ readthedocs-sphinx-ext pytest ]; |
There was a problem hiding this comment.
Can you switch to pytestCheckHook?
| homepage = "https://github.com/snide/sphinx_rtd_theme/"; | ||
| license = licenses.bsd3; | ||
| homepage = "https://github.com/readthedocs/sphinx_rtd_theme"; | ||
| license = licenses.mit; |
There was a problem hiding this comment.
The package is missing a maintainer.
|
Pushed 80e725f to staging-next. Thank you. |
Motivation for this change
Update to the new version. It uses the hack mentioned in readthedocs/sphinx_rtd_theme#1014 of setting CI=1 to avoid running npm.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)