Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

free42: add desktop item #118468

Merged
merged 1 commit into from Apr 8, 2021
Merged

free42: add desktop item #118468

merged 1 commit into from Apr 8, 2021

Conversation

plabadens
Copy link
Contributor

Motivation for this change

Add a desktop item for the free42dec variant of Free42. It's unclear to me whether another one should be made for free42bin. Maybe it would be preferable to add a package option to select between the two?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@plabadens
Copy link
Contributor Author

I'm unsure what's the best way of exposing free42dec and free42bin in desktop items. Would it make sense to add two package options and allow users to select which binaries to build? In that case we'd have one desktop item for each variant. On the other hand, I would assume most users don't need free42bin, as precision is more important than performance in a calculator app.

@AndersonTorres what do you think is preferable?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Apr 7, 2021

Two desktop icons for one package is fine. We don't need to clutter the package list with such small decisions.

@AndersonTorres
Copy link
Member

Two desktop items, one for each binary file.

After all, the other distros build the two executables. The end-user is the one to worry about those minor practical issues.

@plabadens
Copy link
Contributor Author

plabadens commented Apr 7, 2021

Sounds good, I'll keep it simple and just add a second desktop item for free42bin.

Add a desktop item for both the `free42bin1 and `free42dec` variant of
Free42.
@plabadens
Copy link
Contributor Author

Alright, both binaries have desktop icons now.

@AndersonTorres AndersonTorres merged commit 71433ce into NixOS:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants