Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k3s: 1.20.4+k3s1 -> 1.20.5+k3s1 #118822

Merged
merged 1 commit into from Apr 9, 2021
Merged

k3s: 1.20.4+k3s1 -> 1.20.5+k3s1 #118822

merged 1 commit into from Apr 9, 2021

Conversation

superherointj
Copy link
Contributor

k3s: 1.20.4+k3s1 -> 1.20.5+k3s1

Tested on aarch64.

@superherointj superherointj requested a review from euank April 8, 2021 15:28
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 8, 2021 •
edited

Result of nixpkgs-review pr 118822 at 296458ae run on x86_64-linux 1

1 package built successfully:
  • k3s
2 suggestions:
  • warning: build-tools-in-build-inputs

    makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/applications/networking/cluster/k3s/default.nix:251:3:

        |
251 |   buildInputs = [
    |   ^
  • warning: build-tools-in-build-inputs

    util-linux is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/applications/networking/cluster/k3s/default.nix:251:3:

        |
251 |   buildInputs = [
    |   ^

Result of nixpkgs-review pr 118822 at 296458ae run on aarch64-linux 1

1 package built successfully:
  • k3s

@SuperSandro2000
Copy link
Member

Can you add the suggestion from the bot?

@superherointj
k3s: 1.20.4+k3s1 -> 1.20.5+k3s1
8eaac77 
Extra:
@r-rmcgibbo bot requested 'makeWrapper' to be moved from buildInputs to nativeBuildInputs.
@superherointj
Copy link
Contributor Author

superherointj commented Apr 8, 2021 •
edited

Can you add the suggestion from the bot?

  • Moved 'makeWrapper' from buildInputs to nativeBuildInputs. [Ok]
  • Haven't moved 'util-linux' because it seems to be a kubelet runtime dependency. As I am not acquainted with internals of this I'd prefer leaving it as it is.
    • How can the bot be notified of this?

euank
euank approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@euank euank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@bachp bachp merged commit c80690a into NixOS:master Apr 9, 2021
@superherointj superherointj deleted the package-k3s-v1.20.5+k3s1 branch June 23, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachp bachp bachp approved these changes

@euank euank euank approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@superherointj @r-rmcgibbo @SuperSandro2000 @bachp @euank