New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python3Packages.pyobjc: 7.0.1 -> 7.1 #118851
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GameCenter relies on GameCenterFoundation and GameCenterUI, which finally gives the push needed to start checking and fixing the TBD reexports for TBD-only frameworks.
pyobjc is effectively a bunch of Python bindings to a whole heap of the frameworks in the Apple SDK - as such, we need to be able to declare dependencies on a consistent set of frameworks as exposed by a particular macOS SDK version. Since the current SDK version fetched here is 10.12, this commit exports all the frameworks that pyobjc expects for macOS 10.12.
At the same time, this actually fixes the build so it works at all; previously it was both disabled on Python 3, and not working on Python 2.7. pyobjc actually consists of a bunch of sub-modules (one for each wrapped framework, give-or-take). For parallelising the build at maximum efficiency, as well as allowing subpackages to select only the pyobjc dependencies which they actually need, we package each of the submodules individually, rather than pyobjc as a single coherent unit. To make this easier, we use the GitHub src archive, and patch it once upfront, which means we only need to move a single src pointer as we update (rather than fetching from PyPI, which would entail having separate fetch directives for each submodule). Additional packaging notes: * A lot of the exposed APIs are SDK-version-dependent, and nixpkgs takes great pains to expose separate frameworks from the SDK separately. In order for this to work, we patch out all the SDK version checks to instead use an environment variable with the macOS version, which we fix at 10.12 (which is, as of writing, the SDK version used). * LaunchServices just appears to be broken, and this breaks importing the entire CoreServices module. That's patched too. * iTunesLibrary is not actually a core macOS framework, but is usually provided in pyobjc. I don't want to delve into figuring out how to expose it properly as a framework, so for the purposes of getting a basic package up for review I've just dropped it. * Given the large number of frameworks that are needed it's impractical to separately provide these as arguments to pyobjc, so the entire frameworks attrset is provided as an argument instead.
lukegb
commented
Apr 8, 2021
|
||
# Tests for -core don't run, and then the other tests don't work anyway. | ||
doCheck = false; | ||
#pythonImportsCheck = [ pythonModuleName ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to uncomment this before this is merged, whoops(!)
Ah, this'll have to go against staging since it touches the SDK bits. |
Closed
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The primary motivation is... that pyobjc doesn't actually build at master.
Below follows the commit message for python3Packages.pyobjc, but the individual commits have pretty lengthy commit messages that explain the rationale behind each of them.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)