Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunderbird, thunderbird-bin: 78.9.0 -> 78.9.1 [Moderate security fixes] #118889

Merged
merged 2 commits into from Apr 9, 2021

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Apr 9, 2021

Motivation for this change
  • Moderate security fixes.
  • Support recipient aliases for OpenPGP encryption.
  • Other fixes.

https://www.thunderbird.net/en-US/thunderbird/78.9.1/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2021-13/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 118889 at 45754ad run on x86_64-linux 1

1 package skipped due to time constraints:
  • thunderbird (thunderbird-78)
1 package built successfully:
  • thunderbird-bin (thunderbird-bin-78)
3 suggestions:
  • warning: build-tools-in-build-inputs

    zip is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/applications/networking/mailreaders/thunderbird/default.nix:105:3:

        |
    105 |   buildInputs = [
        |   ^
    
  • warning: missing-patch-comment

    Please add a comment on the line above, explaining the purpose of this patch.
    Near pkgs/applications/networking/mailreaders/thunderbird/default.nix:153:5:

        |
    153 |     ./no-buildconfig.patch
        |     ^
    
  • warning: unused-argument

    Unused argument: fetchpatch.
    Near pkgs/applications/networking/mailreaders/thunderbird/default.nix:10:3:

       |
    10 | , fetchpatch
       |   ^
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants