nixos/gitlab: Add options to tame GitLab's memory usage somewhat #118898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restart sidekiq automatically when it consumes too much memory. See https://docs.gitlab.com/ee/administration/operations/sidekiq_memory_killer.html for details.
This should reduce memory fragmentation drastically and is recommended by both the Puma and the Sidekiq author. It's also the default value for Ruby deployments on Heroku.
talyz
force-pushed
the
gitlab-memory-bloat
branch
from
abc95d0
to
6389170
Compare
|
I've been using this in production for more than two weeks without issues. I aim to merge this on Friday unless there are objections. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
GitLab is very memory hungry, but there are a few ways to make it slightly less so.
This adds support for Sidekiq MemoryKiller, allows setting the number of Puma workers and threads, and sets
MALLOC_ARENA_MAXto2.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)