Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.nad-receiver: init at 0.2.0 #118915

Merged
merged 2 commits into from Apr 11, 2021
Merged

python3Packages.nad-receiver: init at 0.2.0 #118915

merged 2 commits into from Apr 11, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Apr 9, 2021 •
edited

Motivation for this change

Python interface for NAD receivers

https://github.com/joopert/nad_receiver

This is a Home Assistant dependency but no tests are available.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Apr 9, 2021

Result of nixpkgs-review pr 118915 run on x86_64-linux 1

2 packages built:
  • python38Packages.nad-receiver
  • python39Packages.nad-receiver

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 118915 at 0e6c257 run on aarch64-linux 1

2 packages built successfully:
  • python38Packages.nad-receiver
  • python39Packages.nad-receiver

@SuperSandro2000
Copy link
Member

Can we activate a home-assistant test?

@fabaff
Copy link
Member Author

fabaff commented Apr 10, 2021

Can we activate a home-assistant test?

There are no tests for the nad integration.

@SuperSandro2000 SuperSandro2000 merged commit 4bdeace into NixOS:master Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @r-rmcgibbo @SuperSandro2000