protoc-gen-twirp: 7.1.1 -> 7.2.0 #118924
Merged
protoc-gen-twirp: 7.1.1 -> 7.2.0 #118924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+21
to
+22
| doCheck = true; | ||
|
|
There was a problem hiding this comment.
This is the default for go.
There was a problem hiding this comment.
For buildGoPackage (used here) the doCheck default value is false, for buildGoModule its true since cc06d7a / 20.09.
The latest build did not run any tests and now it does - at least for the protoc-gen-twirp sub-package. The ..._python sub-package doesn't have any tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update to latest release https://github.com/twitchtv/twirp/releases/tag/v7.2.0. Also enabled
doCheckto run the tests of the two built sub-packages.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)