Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.ptyprocess: fix stuck tests on darwin #118948

Merged
merged 1 commit into from Apr 10, 2021

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented Apr 10, 2021

Motivation for this change

Not sure why ofborg doesn't check darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 118948 at ec0e1f0 run on x86_64-linux 1

168 packages marked as broken and skipped:
  • agdaPackages.iowa-stdlib
  • apostrophe
  • aqemu
  • awsebcli
  • bareos
  • bonfire
  • cassandra_2_1
  • cassandra_2_2
  • couchdb
  • gnome3.gnome-documents
  • ...
10484 packages skipped due to time constraints:
  • DisnixWebService
  • EBTKS
  • Fabric (python38Packages.Fabric)
  • R
  • abcl
  • acd-cli
  • acousticbrainz-client
  • actdiag (python38Packages.actdiag)
  • adafruit-ampy
  • adapta-gtk-theme
  • ...
29 packages built successfully:
  • python38Packages.argon2_cffi
  • python38Packages.betamax
  • python38Packages.cachecontrol
  • python38Packages.chardet
  • python38Packages.factory_boy
  • python38Packages.faker
  • python38Packages.flask
  • python38Packages.flask_sqlalchemy
  • python38Packages.hypothesis
  • python38Packages.isort
  • python38Packages.pexpect
  • python38Packages.poetry-core
  • python38Packages.ptyprocess
  • python38Packages.pytest-localserver
  • python38Packages.pytest-timeout
  • python38Packages.requests
  • python38Packages.requests_download
  • python38Packages.responses
  • python38Packages.sphinx
  • python38Packages.terminado
  • python38Packages.validators
  • python38Packages.virtualenv
  • python38Packages.werkzeug
  • python39Packages.ipython
  • python39Packages.jupyter_core
  • python39Packages.pexpect
  • python39Packages.ptyprocess
  • python39Packages.pytest-timeout
  • python39Packages.terminado
1 suggestion:
  • warning: maintainers-missing

    Package does not have a maintainer. Consider adding yourself?

    Near pkgs/development/python-modules/ptyprocess/default.nix:24:3:

       |
    24 |   meta = {
       |   ^
    

@veprbl
Copy link
Member

veprbl commented Apr 10, 2021

Result of nixpkgs-review pr 118948 run on x86_64-darwin 1

1 package built:
  • python3Packages.ptyprocess

@veprbl veprbl added this to WIP in Staging via automation Apr 10, 2021
@veprbl veprbl moved this from WIP to Ready in Staging Apr 10, 2021
@veprbl veprbl merged commit 66d1da7 into NixOS:staging Apr 10, 2021
Staging automation moved this from Ready to Done Apr 10, 2021
@SuperSandro2000
Copy link
Member

Not sure why ofborg doesn't check darwin.

Because it has no or to little darwin builders and if everything is done except darwin it is ignored.

@bobrik bobrik deleted the ivan/ptyprocess-0.7.0-darwin branch April 13, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Staging
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants