Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdogs-sdl: init at 0.11.0 #118949

Merged
merged 2 commits into from Apr 10, 2021
Merged

cdogs-sdl: init at 0.11.0 #118949

merged 2 commits into from Apr 10, 2021

Conversation

nixinator
Copy link
Member

Motivation for this change

Bring the game cdogs-sdl to nix/OS

Thanks to @jonringer for the help with this package and the python protobuf nix code.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Apr 10, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

jonringer
jonringer reviewed Apr 10, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird, wasn't included in the first review

otherwise LGTM

pkgs/games/cdogs-sdl/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000 @jonringer
Update pkgs/games/cdogs-sdl/default.nix
10146db 
Co-authored-by: Jonathan Ringer <jonringer@users.noreply.github.com>
@SuperSandro2000 SuperSandro2000 merged commit 3314db5 into NixOS:master Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nixinator @jonringer @SuperSandro2000