Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jasper: 2.0.26 -> 2.0.28 #118976

Merged
merged 1 commit into from Apr 11, 2021
Merged

jasper: 2.0.26 -> 2.0.28 #118976

merged 1 commit into from Apr 11, 2021

Conversation

LeSuisse
Copy link
Contributor

Motivation for this change

Fixes CVE-2021-3443.

Release notes:
https://github.com/jasper-software/jasper/releases/tag/version-2.0.27
https://github.com/jasper-software/jasper/releases/tag/version-2.0.28

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • jasper

@ofborg ofborg bot requested a review from AndersonTorres April 10, 2021 07:43
@risicle
Copy link
Contributor

risicle commented Apr 10, 2021

nixpkgs-review happy, macos 10.14

risicle
risicle approved these changes Apr 10, 2021
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review happy, linux x86_64

@AndersonTorres AndersonTorres merged commit 39a4f17 into NixOS:master Apr 11, 2021
@AndersonTorres AndersonTorres added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 11, 2021
@risicle
Copy link
Contributor

risicle commented Apr 11, 2021 •
edited

I'm on the backport. (I'll bump to 2.0.27) Nope I'll just do a straight backport - all the changes seem like fixes to undesirable behaviour.

@risicle
Copy link
Contributor

risicle commented Apr 11, 2021

Hold on, backport not needed - it had been removed for the 20.09 release (in 3a38cef)

@risicle risicle removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 11, 2021
@LeSuisse LeSuisse deleted the jasper-2.0.28 branch April 11, 2021 16:38
@AndersonTorres
Copy link
Member

That removal occurred before the 20.09 release?

@risicle
Copy link
Contributor

risicle commented Apr 12, 2021 •
edited

Hmm. No it didn't. I am confused now. Either way, this file categorically does not exist in the release-20.09 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@risicle risicle risicle approved these changes

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LeSuisse @risicle @AndersonTorres