New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
astc-encoder: init at 2.5 #119018
astc-encoder: init at 2.5 #119018
Conversation
a82780c
to
6f7fd4f
Compare
6f7fd4f
to
73632e4
Compare
@SuperSandro2000 Thanks for your suggestions. I added the compile settings for ARM and other platforms. I tested the changes by cross-compiling with |
afef13d
to
29e3afe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with this change
29e3afe
to
7860ce5
Compare
Fails to build for me, macos 10.14.
edit: I think it's trying to find |
Thanks for noticing the build error on Mac. After installing nix and trying the build myself, I got the same problem. I'm not sure if this is easy to fix. If not, I'll mark the package as linux-only in the meantime. |
This builds the astc-encoder with the appropriate SIMD instructions automatically selected depending on host machine.
7860ce5
to
d94462e
Compare
@risicle I got the macOS build fixed by switching from stdenv to gccStdenv |
Ah well done - I'm sure it's possible to get it working using clang but it's a bit beyond my darwin-fu. |
This builds the astc-encoder for the x86_64 architecture and sets
an astcenc symlink for the most compatible sse2 version.
Motivation for this change
I use the ASTC format for texture compression in a mobile game I develop with LibGDX, as it can encode alpha values and is supported by hardware on modern iOS and Android devices. This is a command line utility for converting regular images (optionally created by a texture packer) into the ASTC or KTX format.
Usage example:
astcenc -cl input.png compressed.astc 6x6 -medium
astcenc -dl compressed.astc decompressed.png
Original source on Github: https://github.com/ARM-software/astc-encoder
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)