Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vimPlugins: add vim-autotag, vim-easytags #119042

Closed
wants to merge 3 commits into from
Closed

vimPlugins: add vim-autotag, vim-easytags #119042

wants to merge 3 commits into from

Conversation

onsails
Copy link
Contributor

@onsails onsails commented Apr 10, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@onsails onsails requested a review from jonringer as a code owner April 10, 2021 14:44
@onsails onsails changed the title vimPlugins: add vim-easytags vimPlugins: add vim-autotag Apr 10, 2021
@onsails onsails changed the title vimPlugins: add vim-autotag vimPlugins: add vim-autotag, vim-easytags Apr 10, 2021
@onsails
Copy link
Contributor Author

onsails commented Apr 10, 2021

@GrahamcOfBorg eval

SuperSandro2000
SuperSandro2000 reviewed Apr 10, 2021
View reviewed changes
pkgs/misc/vim-plugins/vim-plugin-names
@@ -729,6 +730,7 @@ wlangstroth/vim-racket
wsdjeg/vim-fetch
xavierd/clang_complete
xolox/vim-easytags
xolox/vim-easytags
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already in vimPackages. See the line above.

@onsails onsails closed this Apr 10, 2021
@onsails
Copy link
Contributor Author

onsails commented Apr 10, 2021

sorry, I forgot to convert it to draft. Closing due to major problems with autotags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: vim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@onsails @SuperSandro2000