kicad: include desktop, icon and mime files #119055
Conversation
| ]) | ||
| ) | ||
| ; | ||
|
|
||
| postInstall = '' | ||
| install -d $out/share |
There was a problem hiding this comment.
| install -d $out/share | |
| mkdir -p $out/share |
|
Result of 2 packages built successfully:
1 suggestion:
|
| @@ -216,6 +216,8 @@ stdenv.mkDerivation rec { | |||
| in | |||
| (concatStringsSep "\n" | |||
| (flatten [ | |||
| "runHook preInstall" | |||
There was a problem hiding this comment.
Hooks need to be explicitly called by the installPhase script. Even if there isn't a preInstall hook, users may define their own using overrideAttrs.
https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-phase-hooks.md
| @@ -227,10 +229,19 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| # link in the CLI utils | |||
| (map (util: "ln -s ${base}/bin/${util} $out/bin/${util}") utils) | |||
|
|
|||
| "runHook postInstall" | |||
There was a problem hiding this comment.
any idea why this has to be added explicitly?
There was a problem hiding this comment.
Because you are overwriting the phase that normally runs those.
There was a problem hiding this comment.
LGTM
@evils LGTY? nvm, should have read the above more closely.
|
@ofborg eval |
Motivation for this change
Fixes #106295.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)