New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
obs-websocket: init at 4.9.0 #119057
obs-websocket: init at 4.9.0 #119057
Conversation
}.${stdenv.targetPlatform.system} or (throw "Unsupported system: ${stdenv.targetPlatform.system}"); | ||
in '' | ||
mkdir -p $out/share/obs/obs-plugins/obs-websocket/${pluginPath} | ||
ln -s $out/lib/obs-plugins/obs-websocket.so $out/share/obs/obs-plugins/obs-websocket/${pluginPath} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe move it if it is only required in the target directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be required. It is also done by https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/video/obs-studio/v4l2sink.nix#L38 and https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/video/obs-studio/obs-gstreamer.nix#L25.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I contact obs-studio Nix package maintainer to have the idea clear on that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't be necessary once #125308 is merged. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I will add the plugin to pkgs/applications/video/obs-studio/plugins/default.nix
once the plugin wrapper is merged :)
Motivation for this change
OBS websocket plugin enables users to remote control their OBS-Studio instance over the network.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)