Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kime: init at 2.5.2 #119058

Merged
merged 2 commits into from Apr 19, 2021
Merged

kime: init at 2.5.2 #119058

merged 2 commits into from Apr 19, 2021

Conversation

Riey
Copy link
Member

@Riey Riey commented Apr 10, 2021

Motivation for this change

kime is new IME for Korean users it support gtk, qt, xim, wayland(unstable-v2)

https://github.com/Riey/kime

I've tested working with gtk3, qt5, xim, wayland

However I'm not sure this line is correct

https://github.com/NixOS/nixpkgs/blob/76adb53a9252055ee093fa92e56840749207e5eb/nixos/modules/i18n/input-method/kime.nix#L48

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 10, 2021 •
edited

Result of nixpkgs-review pr 119058 at 76adb53a run on x86_64-linux 1

1 package built successfully:
  • kime
4 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/tools/inputmethods/kime/default.nix:60:3:

       |
60 |   installPhase = ''
   |   ^
  • warning: unclear-gpl

    gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/tools/inputmethods/kime/default.nix:110:5:

        |
110 |     license = licenses.gpl3;
    |     ^
  • warning: missing-phase-hooks

    checkPhase should probably contain runHook preCheck and runHook postCheck.

    Near pkgs/tools/inputmethods/kime/default.nix:56:3:

       |
56 |   checkPhase = ''
   |   ^
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/tools/inputmethods/kime/default.nix:45:3:

       |
45 |   buildPhase = ''
   |   ^

Result of nixpkgs-review pr 119058 at 76adb53a run on aarch64-linux 1

1 package built successfully:
  • kime

SuperSandro2000
SuperSandro2000 requested changes Apr 10, 2021
View reviewed changes
nixos/modules/i18n/input-method/kime.nix Outdated Show resolved Hide resolved
nixos/modules/i18n/input-method/kime.nix Outdated Show resolved Hide resolved
pkgs/tools/inputmethods/kime/default.nix Outdated Show resolved Hide resolved
pkgs/tools/inputmethods/kime/default.nix Outdated Show resolved Hide resolved
pkgs/tools/inputmethods/kime/default.nix Outdated Show resolved Hide resolved
pkgs/tools/inputmethods/kime/default.nix Outdated Show resolved Hide resolved
pkgs/tools/inputmethods/kime/default.nix Outdated Show resolved Hide resolved
pkgs/tools/inputmethods/kime/default.nix Outdated Show resolved Hide resolved
pkgs/tools/inputmethods/kime/default.nix Outdated Show resolved Hide resolved
@Riey Riey force-pushed the kime branch 3 times, most recently from 3a9f3bc to cfcbaf9 Compare April 11, 2021 04:32
@Riey Riey force-pushed the kime branch 2 times, most recently from 9f6f335 to 5043b4f Compare April 12, 2021 15:09
@Riey Riey changed the title kime: init at 2.4.0 kime: init at 2.5.0 Apr 12, 2021
@Riey Riey changed the title kime: init at 2.5.0 kime: init at 2.5.1 Apr 12, 2021
aanderse
aanderse reviewed Apr 13, 2021
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. A minor wording suggestion on one of the descriptions.

Did you build/validate the manual to make sure there are no errors?

nixos/modules/i18n/input-method/kime.nix Outdated Show resolved Hide resolved
nixos/modules/i18n/input-method/kime.nix Show resolved Hide resolved
@Riey
Copy link
Member Author

Riey commented Apr 13, 2021

@aanderse I check manual with this script from CI NIX_PATH=nixpkgs=$(pwd) nix-build --option restrict-eval true nixos/release.nix -A manual.x86_64-linux

Rendered

20210413141003

@Riey
Copy link
Member Author

Riey commented Apr 13, 2021

I think I have to fix broken pipe error on aarch64 but I have no idea why it occured 😕

@Riey
Copy link
Member Author

Riey commented Apr 13, 2021

I found related issue rust-lang/rust#46016

SuperSandro2000
SuperSandro2000 approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package LGTM

@Riey
Copy link
Member Author

Riey commented Apr 14, 2021

@SuperSandro2000 what's left for merge this?

@SuperSandro2000
Copy link
Member

what's left for merge this?

Someone like aanderse should look at the module and tests.

aanderse
aanderse approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, thought I had approved this. LGTM 👍

@Riey
Copy link
Member Author

Riey commented Apr 15, 2021

@SuperSandro2000 Can this merge now?

@Riey Riey changed the title kime: init at 2.5.1 kime: init at 2.5.2 Apr 15, 2021
@Riey
Copy link
Member Author

Riey commented Apr 17, 2021

Ping @SuperSandro2000 please merge this

SuperSandro2000
SuperSandro2000 reviewed Apr 17, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please put the module and package into a separate commit.

pkgs/tools/inputmethods/kime/default.nix Outdated Show resolved Hide resolved
@Riey Riey force-pushed the kime branch 2 times, most recently from e77162d to 88c9121 Compare April 17, 2021 15:50
@Riey
Copy link
Member Author

Riey commented Apr 18, 2021

@SuperSandro2000 I split commit

@SuperSandro2000 SuperSandro2000 merged commit b0899c7 into NixOS:master Apr 19, 2021
@Riey Riey deleted the kime branch April 19, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Riey @r-rmcgibbo @SuperSandro2000 @aanderse