Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rink: 0.5.1 -> 0.6.0 #119146

Merged
merged 2 commits into from Apr 11, 2021
Merged

rink: 0.5.1 -> 0.6.0 #119146

merged 2 commits into from Apr 11, 2021

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/tiffany352/rink-rs/releases.

meta.description for rink is: "Unit-aware calculator"

meta.homepage for rink is: "https://rinkcalc.app"

meta.changelog for rink is: ""

Updates performed
  • Rust version update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • /nix/store/x2m48sf7ligjl4p7j1g46nasazcnc8wh-rink-0.6.0/bin/rink passed the binary check.

  • 1 of 1 passed binary check by having a zero exit code.

  • 1 of 1 passed binary check by having the new version present in output.

  • found 0.6.0 with grep in /nix/store/x2m48sf7ligjl4p7j1g46nasazcnc8wh-rink-0.6.0

  • found 0.6.0 in filename of file in /nix/store/x2m48sf7ligjl4p7j1g46nasazcnc8wh-rink-0.6.0

  • directory tree listing: https://gist.github.com/966c4d311de63506796a6955a476c8e7

  • du listing: https://gist.github.com/d7652276bbb3347f0bbd706f5f7dfdf7


Rebuild report (if merged into master) (click to expand)
4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
rink
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/x2m48sf7ligjl4p7j1g46nasazcnc8wh-rink-0.6.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A rink https://github.com/r-ryantm/nixpkgs/archive/12518ff683a46858bbe06aaf5fef4b88b4ea9e15.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/x2m48sf7ligjl4p7j1g46nasazcnc8wh-rink-0.6.0
ls -la /nix/store/x2m48sf7ligjl4p7j1g46nasazcnc8wh-rink-0.6.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • rink

Maintainer pings

cc @sbourdeauducq @Br1ght0ne for testing.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 11, 2021

Result of nixpkgs-review pr 119146 at 12518ff6 run on x86_64-linux 1

1 package built successfully:
  • rink
1 suggestion:
  • warning: unclear-gpl

    gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/applications/science/misc/rink/default.nix:25:5:

       |
    25 |     license = with licenses; [ mpl20 gpl3 ];
       |     ^
    

Result of nixpkgs-review pr 119146 at 12518ff6 run on aarch64-linux 1

1 package built successfully:
  • rink

@fabaff
Copy link
Member

fabaff commented Apr 11, 2021

Result of nixpkgs-review pr 119146 run on x86_64-linux 1

1 package built:
  • rink

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...ew/pr-119146]$ ./results/rink/bin/rink 

   0: Failed to load currency data
   1: Failed to fetch currency.json
   2: Failed to write to cache dir
   3: failed to persist temporary file: Invalid cross-device link (os error 18)
   4: Invalid cross-device link (os error 18)

Backtrace omitted.
Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.
> 4*3
12  (dimensionless)
[...]

Change looks good to me.

@fabaff fabaff merged commit 332b304 into NixOS:master Apr 11, 2021
@r-ryantm r-ryantm deleted the auto-update/rink branch April 14, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants