Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sickgear: 0.23.15 -> 0.23.16 #119160

Merged
merged 1 commit into from May 9, 2021
Merged

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/SickGear/SickGear/releases.

meta.description for sickgear is: "The most reliable stable TV fork of the great Sick-Beard to fully automate TV enjoyment with innovation"

meta.homepage for sickgear is: "https://github.com/SickGear/SickGear"

meta.changelog for sickgear is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS

  • The tests defined in passthru.tests, if any, passed

  • Warning: no invocation of /nix/store/z51v42y7xy1xw8is3r5vsm69xhkc9mzp-sickgear-0.23.16/bin/sickgear had a zero exit code or showed the expected version

  • 0 of 1 passed binary check by having a zero exit code.

  • 0 of 1 passed binary check by having the new version present in output.

  • found 0.23.16 with grep in /nix/store/z51v42y7xy1xw8is3r5vsm69xhkc9mzp-sickgear-0.23.16

  • found 0.23.16 in filename of file in /nix/store/z51v42y7xy1xw8is3r5vsm69xhkc9mzp-sickgear-0.23.16

  • directory tree listing: https://gist.github.com/43bdb7f938e9d72158ac108cacb7bcf6

  • du listing: https://gist.github.com/ebff63beeaa25558c561079dd10eb306


Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
sickgear
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/z51v42y7xy1xw8is3r5vsm69xhkc9mzp-sickgear-0.23.16 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A sickgear https://github.com/r-ryantm/nixpkgs/archive/7539ba07a211bf2153a62ca9478fe61d7b3cedb5.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/z51v42y7xy1xw8is3r5vsm69xhkc9mzp-sickgear-0.23.16
ls -la /nix/store/z51v42y7xy1xw8is3r5vsm69xhkc9mzp-sickgear-0.23.16/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • sickgear

Maintainer pings

cc @rembo10 for testing.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 119160 at 7539ba0 run on x86_64-linux 1

1 package built successfully:
  • sickgear
2 suggestions:
  • warning: unclear-gpl

    gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/servers/sickbeard/sickgear.nix:31:5:

       |
    31 |     license     = licenses.gpl3;
       |     ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/servers/sickbeard/sickgear.nix:22:3:

       |
    22 |   installPhase = ''
       |   ^
    

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/NixOS/nixpkgs/pull/119160

1 package built:
sickgear

@jonringer jonringer merged commit 69090bc into NixOS:master May 9, 2021
@r-ryantm r-ryantm deleted the auto-update/sickgear branch May 9, 2021 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants