Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

medfile: use HDF5 1.12 #119171

Merged
merged 1 commit into from Apr 11, 2021
Merged

medfile: use HDF5 1.12 #119171

merged 1 commit into from Apr 11, 2021

Conversation

LeSuisse
Copy link
Contributor

Motivation for this change

HDF5 1.10 has known security issues (CVE-2020-10809, CVE-2020-10810, CVE-2020-10811 and CVE-2020-10812).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

2 packages built:
  • freecad
  • medfile

@LeSuisse LeSuisse requested a review from gebner April 11, 2021 17:45
@gebner gebner merged commit df57532 into NixOS:master Apr 11, 2021
@gebner
Copy link
Member

gebner commented Apr 11, 2021

Thanks!

@LeSuisse LeSuisse deleted the medfile-hdf5-1.12 branch April 11, 2021 18:13
SuperSandro2000
SuperSandro2000 reviewed Apr 11, 2021
View reviewed changes
pkgs/development/libraries/medfile/default.nix
@@ -9,6 +9,10 @@ stdenv.mkDerivation rec {
sha256 = "1khzclkrd1yn9mz3g14ndgpsbj8j50v8dsjarcj6kkn9zgbbazc4";
};

patches = [
./hdf5-1.12.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this patch be fetched instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built it from scratch so unfortunately no. Where and how the development of medfile/medfichier happens is a bit unclear how we can work with upstream on this 😞

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well thats unfortunate.

@gebner gebner mentioned this pull request Feb 27, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@gebner gebner Awaiting requested review from gebner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LeSuisse @gebner @SuperSandro2000