Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irssi: 1.2.2 -> 1.2.3 #119173

Merged
merged 1 commit into from Apr 11, 2021
Merged

irssi: 1.2.2 -> 1.2.3 #119173

merged 1 commit into from Apr 11, 2021

Conversation

LeSuisse
Copy link
Contributor

Motivation for this change

Release notes:
https://github.com/irssi/irssi/releases/tag/1.2.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

2 packages built:
  • irssi
  • irssi_fish

@fabaff
Copy link
Member

fabaff commented Apr 11, 2021

Result of nixpkgs-review pr 119173 run on x86_64-linux 1

2 packages built:
  • irssi
  • irssi_fish

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...ew/pr-119173]$ ./results/irssi/bin/irssi -v
irssi 1.2.3 (20210409 0011)

Change looks good to me. TUI works.

@SuperSandro2000 SuperSandro2000 merged commit c0339b0 into NixOS:master Apr 11, 2021
@LeSuisse LeSuisse deleted the irssi-1.2.3 branch April 12, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants