Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python2Packages.pycairo: init at 1.18.2 #119185

Merged
merged 2 commits into from Apr 12, 2021
Merged

python2Packages.pycairo: init at 1.18.2 #119185

merged 2 commits into from Apr 12, 2021

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Apr 11, 2021 •
edited

Motivation for this change

fixes #119174

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

We should also try building Gtk2 with Python 3.

@dotlambda dotlambda requested review from davidak, jonringer and a team April 11, 2021 19:33
@dotlambda dotlambda requested a review from FRidh as a code owner April 11, 2021 19:33
@SuperSandro2000
Copy link
Member

Does this need to target staging?

@dotlambda
Copy link
Member Author

Does this need to target staging?

It doesn't make sense not to cause python3Packages.pycairo is on 1.18.2 in staging-next.

@davidak
Copy link
Member

davidak commented Apr 11, 2021

In the linked issue, gimp needed the python 2 version, so should it be used in this PR or in a different?

I tried to build gimp from this PR, but it also builds LLVM which takes forever, so it stopped it.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 119185 run on x86_64-linux 1

1 package built:
  • gimp

davidak
davidak approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@davidak davidak merged commit 53c7f16 into NixOS:staging Apr 12, 2021
@dotlambda dotlambda deleted the pycairo-python2 branch April 12, 2021 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@jonringer jonringer Awaiting requested review from jonringer

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @SuperSandro2000 @davidak