Fix python mpv module #119194
Closed
Fix python mpv module #119194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,10 +16,10 @@ buildPythonPackage rec { | |||
|
|
|||
| buildInputs = [ mpv ]; | |||
|
|
|||
| postPatch = '' | |||
| patchPhase = '' | |||
There was a problem hiding this comment.
Suggested change
| patchPhase = '' | |
| postPatch = '' |
otherwise patches breaks.
There was a problem hiding this comment.
postPatch wasn't applying correctly when included in Sublime Music (I inspected the mpv.py file manually in the /nix store and it wasn't correctly updated...)
There was a problem hiding this comment.
postPatch is run in patchPhase when it isn't overwriten. There shouldn't be any difference.
sumnerevans
force-pushed
the
fix-python-mpv-module
branch
from
5fc1a67
to
3088140
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
When the
python3Packages.mpvpackage is included in another package viabuildInputs(for example, from Sublime Music: https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/audio/sublime-music/default.nix#L39), thepostPatchhook wasn't actually causing the necessary replacement to occur.This PR fixes that by moving the substitution to the
patchPhase. This PR also adds myself as the maintainer of the python-mpv module.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)