Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.karton-dashboard: init at 1.1.0 #119214

Merged
merged 1 commit into from Apr 22, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Apr 12, 2021

Motivation for this change

Web application that allows for Karton task and queue introspection

https://github.com/CERT-Polska/karton-dashboard

Related to #81418

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@chivay, perhaps you could give it a try please?

@fabaff
Copy link
Member Author

fabaff commented Apr 12, 2021

Result of nixpkgs-review pr 119214 run on x86_64-linux 1

2 packages built:
  • python38Packages.karton-dashboard
  • python39Packages.karton-dashboard

Copy link
Member

@chivay chivay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on NixOS

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 12, 2021

Result of nixpkgs-review pr 119214 at 05e607bd run on x86_64-linux 1

2 packages built successfully:
  • python38Packages.karton-dashboard
  • python39Packages.karton-dashboard
1 suggestion:
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/karton-dashboard/default.nix:38:0:

       |
    38 |     description = "Web application that allows for Karton task and queue introspection";
       | ^
    

Result of nixpkgs-review pr 119214 at 05e607bd run on aarch64-linux 1

2 packages built successfully:
  • python38Packages.karton-dashboard
  • python39Packages.karton-dashboard
1 suggestion:
  • warning: python-include-tests

    Consider adding a checkPhase for tests, or if not feasible, pythonImportsCheck.

    Near pkgs/development/python-modules/karton-dashboard/default.nix:38:0:

       |
    38 |     description = "Web application that allows for Karton task and queue introspection";
       | ^
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants