python3Packages.tables: fix usage, add tests #119258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewrisinger
changed the title
I miss understood that. Yeah, changing hdf5_1_10 would be an option. |
|
Result of 59 packages marked as broken and skipped:
1 package failed to build:307 packages skipped due to time constraints:
32 packages built successfully:
1 suggestion:
Note that build failures may predate this PR, and could be nondeterministic or hardware dependent. |
SuperSandro2000
requested changes
Apr 12, 2021
drewrisinger
force-pushed
the
dr-pr-fix-python-tables
branch
2 times, most recently
from
b4232ca
to
c588ada
Compare
8 tasks
* add myself as maintainer * update homepage * incorporate minor patches * add working tests
This package only exists for compatibility with ``python3Packages.tables``, as far as I can tell based on usage in nixpkgs. ``tables`` tests fail on hdf5 > v1.10.5, so we are reverting this to the last "good" version of hdf5 that works with ``tables``. ``hdf5_1_10`` should hopefully be unpinned on the next release of ``python3Packages.tables``. PyTables/PyTables#845
drewrisinger
force-pushed
the
dr-pr-fix-python-tables
branch
from
c588ada
to
19acc79
Compare
|
@bcdarwin gave consent for rolling back hdf5 by a patch-version in #119572 (comment). |
|
This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch). Result of 38 packages marked as broken and skipped:
58 packages failed to build and already failed to build on hydra master:
16 packages failed to build and are new build failures:
336 packages built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
While trying to open a HDF5 file via
python3Packages.pandas, realized that pandas' HDF5 functionality was broken b/cpython3Packages.tableswasn't importing.The main failure I was having was due to setuptools not being installed at runtime (couldn't import
pkg_resources), but also noticed that tests weren't being run.Trying to run the tests found that
tableswasn't compatible withhdf5 v1.10.7(PyTables/PyTables#845).tablesseems to be the only package usinghdf5_1_10(nixpkgs/pkgs/top-level/python-packages.nix
Lines 8232 to 8239 in 311ceed
hdf5_1_10tov1.10.5?I know this probably needs a little bit of work/cleanup, just wanted to get some opinions on this.
Things tried:
Improvements:
pythonImportsCheckpytestCheckHook)Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)