[experiment] try using settings
for peertube
#119262
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
Alternative idea to #119110
@Izorkin This probably won't make it - I just want to get some feedback regarding some problems with this approach and if that can be somehow improved. It would get a mess in the other PR.
@aanderse Pinging you is evil :D but it was your idea and I need some help. (Others are also welcome to help of course)
The important file is the module.
createLocally
andpasswordFile
in this case). Should I use a) the current approach of splitting these up into two places, b) putting the options into settings where they are currently ignored by peertube, c) put all options that are usually needed outside ofsettings
like before (inconsistent) or do you have another idea?settings.storage
options without a lot of option declarations?settings
implementation?sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)