Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] mozjpeg: 3.3.1 -> 4.0.3 #119267

Merged
merged 1 commit into from Apr 24, 2021
Merged

[20.09] mozjpeg: 3.3.1 -> 4.0.3 #119267

merged 1 commit into from Apr 24, 2021

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Apr 12, 2021 •
edited

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2018-14498

Backport of #119117. Attempted patching but was foiled by yet another person running an auto-formatter 馃檮

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LeSuisse @risicle
mozjpeg: 3.3.1 -> 4.0.3
8e93a29 
Fixes CVE-2018-14498.

(cherry picked from commit 7c0db9f)
@ofborg ofborg bot requested a review from aristidb April 12, 2021 22:04
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 12, 2021 •
edited

Result of nixpkgs-review pr 119267 at 8e93a29 run on aarch64-linux 1

3 packages built successfully:
  • avocode
  • jpeg-archive
  • mozjpeg

Result of nixpkgs-review pr 119267 at 8e93a29 run on x86_64-linux 1

4 packages built successfully:
  • avocode
  • image_optim
  • jpeg-archive
  • mozjpeg

LeSuisse
LeSuisse approved these changes Apr 14, 2021
View reviewed changes
Copy link
Contributor

@LeSuisse LeSuisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my end.

Thanks for patch attempt.

@lukegb lukegb merged commit e6911ea into NixOS:release-20.09 Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeSuisse LeSuisse LeSuisse approved these changes

@aristidb aristidb Awaiting requested review from aristidb

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@risicle @r-rmcgibbo @LeSuisse @lukegb