Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kupfer: 319 -> 321 #119303

Merged
merged 1 commit into from Apr 16, 2021
Merged

kupfer: 319 -> 321 #119303

merged 1 commit into from Apr 16, 2021

Conversation

avdv
Copy link
Member

@avdv avdv commented Apr 13, 2021

Motivation for this change

New upstream release: https://github.com/kupferlauncher/kupfer/releases/tag/v321

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

* add itstool to nativeBuildTools for building help pages in different languages
* add desktop-file-utils and shared-mime-info to nativeBuildTools which are
  needed when building
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review on x86-64-linux. Headless machine, so can't test GUI.
1 package built:
kupfer

$ nix-shell /home/drewrisinger/.cache/nixpkgs-review/pr-119303/shell.nix

[nix-shell:~/.cache/nixpkgs-review/pr-119303]$ kupfer --help
Usage: kupfer [ OPTIONS | FILE ... ]

  --no-splash        do not present main interface on launch
  --list-plugins     list available plugins
  --debug            enable debug info
  --exec-helper=     run plugin helper

  --help             show usage help
  --version          show version information


[nix-shell:~/.cache/nixpkgs-review/pr-119303]$ kupfer --list-plugins
Available plugins:
  applications     2017.3     All applications and preferences
  apt_tools                   Interface with the package manager APT
  archiveinside               Allow browsing inside compressed archive files
  archivemanager              Use Archive Manager actions
  audacious        2017.2     Control Audacious playback and playlist
  brotab           2020.1     Firefox Tabs
  calculator       2017.1     Calculate mathematical expressions
  chromium                    Index of Chromium bookmarks
  clawsmail        2018-10-07 Claws Mail Contacts and Actions
  clipboard                   Recent clipboards and clipboard proxy objects
  commands                    Run command-line programs. Actions marked with
                              the symbol ⚙ run in a subshell.
  core                        Core actions and items
  custom_terminal             Configure a custom terminal emulator.  The
                              plugin adds another terminal alternative (select
                              it on the main page).
  darktheme        2017.1
  deepdirectories  2018-09-04 Recursive index directories
  defaultmail      2017.1     Compose email using the system's default mailto:
                              handler
  devhelp          2017.1     Search in Devhelp
  dictionary                  Look up word in dictionary
  documents        2017.3     Recently used documents and bookmarked folders
  duckduckgo       1.0        Search the web securely with DuckDuckGo
  favorites        2009-12-30 Mark commonly used items and store objects for
                              later use
  fileactions                 More file actions
  firefox          2020.1     Index of Firefox bookmarks
  firefox_keywords 2020.1     Search the web with Firefox keywords
  glob                        Select objects using '*' and '?' as wildcards.
  gtg              2017.2     Browse and create new tasks in GTG
  higherorder      2010-01-11 Tools to work with commands as objects
  image            2017.1     Image transformation tools using 'convert' from
                              ImageMagick
  instapaper       2020-11-15 Save url to Instapaper
  kupfer_plugins              Access Kupfer's plugin list in Kupfer
  locate                      Search filesystem using locate
  mediaplayers     2017.1     Playback control for media players
  nemo             2017.1     File manager actions
  notes            2017.2     Gnote or Tomboy notes
  pidgin           2017.1     Access to Pidgin Contacts
  pinboard         2020-11-15 Manage and use bookmarks from Pinboard
  qsicons
  quickview
  rhythmbox        2017.2     Play and enqueue tracks and browse the music
                              library
  screen                      Active GNU Screen sessions
  sendkeys                    Send synthetic keyboard events using xautomation
  session_gnome    2012-10-16 Special items and actions for GNOME environment
  session_lxqt     2020-08-23 Actions for LXQT desktop
  session_xfce     2021-04-11 Special items and actions for XFCE environment
  shorten_links    2017.1     Create short aliases of long URLs
  show_text                   Display text in a window
  ssh_hosts        2010-04-12 Adds the SSH hosts found in ~/.ssh/config.
  templates                   Create new documents from your templates
  textfiles        2017.1
  thunar                      File manager Thunar actions
  thunderbird      2017.2     Thunderbird/Icedove Contacts and Actions
  top              2009-11-24 Show running tasks and allow sending signals to
                              them
  tracker1         2017.2     Tracker desktop search integration
  trash            2017.2     Access trash contents
  triggers         2009-12-30 Assign global keybindings (triggers) to objects
                              created with ‘Compose Command’.
  urlactions                  URL Actions
  virtualbox       0.4        Control VirtualBox Virtual Machines. Supports
                              both Sun VirtualBox and Open Source Edition.
  volumes          2017.2     Mounted volumes and disks
  websearch        2020-04-19 Search the web with OpenSearch search engines
  whatsapp         1.0        Open a new number in WhatsApp Web  The number
                              format must respect: "Country Code" + "Area
                              Code" + "Number"  Example for a New York number:
                              12129999999 Country Code: 1 Area Code: 212
                              Number: 9999999  WhatsApp Web will open in the
                              browser.  For help visit
                              https://faq.whatsapp.com/general/chats/how-to-
                              use-click-to-chat/
  wikipedia        2017.1     Search in Wikipedia
  windows          2020-04-14 All windows on all workspaces

@tomberek
Copy link
Contributor

Result of nixpkgs-review pr 119303 run on x86_64-linux 1

1 package built:
  • kupfer

@tomberek tomberek merged commit b77c77d into NixOS:master Apr 16, 2021
@avdv avdv deleted the kupfer-321 branch April 16, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants