Sublime text 4 #119351
Sublime text 4 #119351
Conversation
* works with my 7 year old license so far * i686 is no longer supported * aarch64 support has been added * adds harware accelerated (needs libGL.so.1) * adds python 3.8 plugin host (needs libssl.so and libcrypto.so)
| sha256 = archSha256; | ||
| }; | ||
|
|
||
| dontStrip = true; |
There was a problem hiding this comment.
It's from this commit: d619f0e
Here they mention it's important for pre-built binary.
#15969 (comment)
I don't know why this is needed. I just copied the code from version 3 and adapted for 4.
There was a problem hiding this comment.
Thats about dwarf fortress. If it doesn't crash sublime we should just strip it.
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
MasseGuillaume
force-pushed
the
sublime-text-4
branch
from
ba8e1a9
to
a762fa0
Compare
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
| }.${stdenv.hostPlatform.system}; | ||
|
|
||
| libPath = lib.makeLibraryPath [ xorg.libX11 glib libglvnd openssl gtk3 cairo pango ]; | ||
| redirects = [ "/usr/bin/pkexec=${pkexecPath}" ]; |
There was a problem hiding this comment.
I kept the package updated in my pkgset:
https://github.com/jtojnar/nixfiles/blob/master/pkgs/sublime4/common.nix
It turned out that libredirect is more trouble than it is worth so I got rid of it:
|
Sublime Text 4 is now released: https://www.sublimetext.com/blog/articles/sublime-text-4 |
|
Will update the PR ASAP. |
| mkdir -p "$out/share/applications" | ||
| substitute "''$${primaryBinary}/${primaryBinary}.desktop" "$out/share/applications/${primaryBinary}.desktop" --replace "/opt/${primaryBinary}/${primaryBinary}" "$out/bin/${primaryBinary}" | ||
| for directory in ''$${primaryBinary}/Icon/*; do | ||
| size=$(basename $directory) |
There was a problem hiding this comment.
$directory and $size could benefit from some quoting, given that they are are from the package and might contain spaces in the future.
There was a problem hiding this comment.
We already iterate over * so that will not help, unless we use the ultra ugly find | read hack.
|
Opened #124057 |
Motivation for this change
resurect #93437
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)