Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lunar-client: 2.4.0 -> 2.6.0 #119355

Merged
merged 2 commits into from Apr 15, 2021
Merged

Conversation

Technical27
Copy link
Contributor

Motivation for this change

The auto updater in lunar client doesn't (and can't) work, and it refuses to run if the version is too old.

Things done

Add myself to maintainers.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Technical27
Copy link
Contributor Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Apr 13, 2021
@marvin-mk2
Copy link

marvin-mk2 bot commented Apr 13, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@kevincox
Copy link
Contributor

kevincox commented Apr 13, 2021

@Technical27 please ping existing maintainers for reviews first. You can use the bot if the maintainer is unresponsive to to get an approved change merged.

@zyansheep can you please provide an initial review?

Copy link
Contributor

@zyansheep zyansheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for taking so long! I tested the pr in 1.8 and 1.16 and it seems to be working ok.

@kevincox kevincox merged commit 3cee82a into NixOS:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants