Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nimmm: 0.1.2 -> 0.2.0 #119359

Merged
merged 1 commit into from Apr 15, 2021
Merged

nimmm: 0.1.2 -> 0.2.0 #119359

merged 1 commit into from Apr 15, 2021

Conversation

joachimschmidt557
Copy link
Member

Motivation for this change

I just released a new version of nimmm: https://github.com/joachimschmidt557/nimmm/releases/tag/v0.2.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 13, 2021

Result of nixpkgs-review pr 119359 at 90209b2 run on x86_64-linux 1

1 package built successfully:
  • nimmm
3 suggestions:
  • warning: unclear-gpl

    gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/applications/terminal-emulators/nimmm/default.nix:51:5:

       |
    51 |     license = licenses.gpl3;
       |     ^
    
  • warning: missing-phase-hooks

    buildPhase should probably contain runHook preBuild and runHook postBuild.

    Near pkgs/applications/terminal-emulators/nimmm/default.nix:39:3:

       |
    39 |   buildPhase = ''
       |   ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/applications/terminal-emulators/nimmm/default.nix:44:3:

       |
    44 |   installPhase = ''
       |   ^
    

Result of nixpkgs-review pr 119359 at 90209b2 run on aarch64-linux 1

1 package built successfully:
  • nimmm

@ehmry ehmry merged commit bdf2f66 into NixOS:master Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants