Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openapi-generator-cli: Use headless jre #119405

Merged

Conversation

roberth
Copy link
Member

@roberth roberth commented Apr 14, 2021

Motivation for this change
  • Remove unnecessary dependency on linux gui libs.
  • Add a test to ease maintenance
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 119405 at cf070262 run on x86_64-linux 1

2 packages built successfully:
  • openapi-generator-cli
  • openapi-generator-cli-unstable
3 suggestions:
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/tools/networking/openapi-generator-cli/default.nix:20:3:

       |
    20 |   installPhase = ''
       |   ^
    
  • warning: unused-argument

    Unused argument: runCommand.
    Near pkgs/tools/networking/openapi-generator-cli/default.nix:1:57:

      |
    1 | { callPackage, lib, stdenv, fetchurl, jre, makeWrapper, runCommand }:
      |                                                         ^
    
  • warning: missing-phase-hooks

    installPhase should probably contain runHook preInstall and runHook postInstall.

    Near pkgs/tools/networking/openapi-generator-cli/unstable.nix:20:3:

       |
    20 |   installPhase = ''
       |   ^
    

@roberth roberth force-pushed the openapi-generator-cli-jre-headless branch from cf07026 to 70b279c Compare April 14, 2021 14:20
@roberth roberth force-pushed the openapi-generator-cli-jre-headless branch from 70b279c to 66fd2ea Compare May 6, 2021 14:28
@roberth
Copy link
Member Author

roberth commented May 6, 2021

Rebased, ready for review and checks have passed.

@domenkozar domenkozar merged commit 0fbace6 into NixOS:master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants