New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add podgrab package and module #119443
Add podgrab package and module #119443
Conversation
I opened an issue upstream about changing the webui's port, given that Also, I wasn't sure how to test the basic authentication when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left a few comments on the module that I hope you will find helpful. Please let me know if you have any questions, etc...
e91996a
to
351544d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The module and test look good 👍
If interested you can list yourself as maintainer of the module too.
I think we're supposed to list maintainers on tests, so maybe consider adding yourself there if you don't mind.
Thanks!
Ah true I forgot to do that, will amend shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package LGTM
Friendly ping about this MR :-) |
Motivation for this change
Closes #117284.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)