Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igraph: 0.9.1 -> 0.9.2 #119447

Merged
merged 1 commit into from Apr 17, 2021
Merged

igraph: 0.9.1 -> 0.9.2 #119447

merged 1 commit into from Apr 17, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change

https://github.com/igraph/igraph/releases/tag/0.9.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 14, 2021

Result of nixpkgs-review pr 119447 at 6f8f5e10 run on x86_64-linux 1

4 packages failed to build:
5 packages built successfully:
  • hal-hardware-analyzer
  • igraph
  • python39Packages.cozy
  • python39Packages.kmapper
  • python39Packages.python-igraph
4 suggestions:
  • warning: build-tools-in-build-inputs

    bison is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/development/libraries/igraph/default.nix:60:3:

       |
    60 |   buildInputs = [
       |   ^
    
  • warning: unused-argument

    Unused argument: fetchpatch.
    Near pkgs/development/libraries/igraph/default.nix:4:3:

      |
    4 | , fetchpatch
      |   ^
    
  • warning: build-tools-in-build-inputs

    yacc is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/development/libraries/igraph/default.nix:60:3:

       |
    60 |   buildInputs = [
       |   ^
    
  • warning: build-tools-in-build-inputs

    flex is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/development/libraries/igraph/default.nix:60:3:

       |
    60 |   buildInputs = [
       |   ^
    

Note that build failures may predate this PR, and could be nondeterministic or hardware dependent.
Please exercise your independent judgement.


Result of nixpkgs-review pr 119447 at 6f8f5e10 run on aarch64-linux 1

9 packages built successfully:
  • hal-hardware-analyzer
  • igraph
  • python38Packages.cozy
  • python38Packages.kmapper
  • python38Packages.python-igraph
  • python38Packages.scikit-tda
  • python39Packages.cozy
  • python39Packages.kmapper
  • python39Packages.python-igraph

};

patches = [
(fetchpatch {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove fetchpatch from inputs.

@dotlambda
Copy link
Member Author

dotlambda commented Apr 15, 2021

  • yacc is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

@rmcgibbo There is no yacc in buildInputs.

Correcting that in jtojnar/nixpkgs-hammering#104.

@SuperSandro2000 SuperSandro2000 merged commit c00fa57 into NixOS:master Apr 17, 2021
@dotlambda dotlambda deleted the igraph-0.9.2 branch April 17, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants