Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inotify-tools: 3.20.2.2 -> 3.20.11.0 #119450

Merged
merged 1 commit into from Apr 19, 2021

Conversation

SCOTT-HAMILTON
Copy link
Contributor

Motivation for this change

Needed the -P flag

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 14, 2021

Result of nixpkgs-review pr 119450 at 8cdcc8f9 run on aarch64-linux 1

12 packages built successfully:
  • appimagekit
  • dovecot
  • dovecot_fts_xapian
  • dovecot_pigeonhole
  • gerbera
  • inotify-tools
  • llpp
  • nextcloud-client
  • sshlatex
  • transmission
  • transmission-gtk
  • transmission-qt
2 suggestions:
  • warning: unused-argument

    Unused argument: fetchpatch.
    Near pkgs/development/tools/misc/inotify-tools/default.nix:1:49:

      |
    1 | { lib, stdenv, autoreconfHook, fetchFromGitHub, fetchpatch }:
      |                                                 ^
    
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/development/tools/misc/inotify-tools/default.nix:18:5:

       |
    18 |     license = licenses.gpl2;
       |     ^
    

Result of nixpkgs-review pr 119450 at 8cdcc8f9 run on x86_64-linux 1

12 packages built successfully:
  • appimagekit
  • dovecot
  • dovecot_fts_xapian
  • dovecot_pigeonhole
  • gerbera
  • inotify-tools
  • llpp
  • nextcloud-client
  • sshlatex
  • transmission
  • transmission-gtk
  • transmission-qt
2 suggestions:
  • warning: unused-argument

    Unused argument: fetchpatch.
    Near pkgs/development/tools/misc/inotify-tools/default.nix:1:49:

      |
    1 | { lib, stdenv, autoreconfHook, fetchFromGitHub, fetchpatch }:
      |                                                 ^
    
  • warning: unclear-gpl

    gpl2 is a deprecated license, please check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

    Near pkgs/development/tools/misc/inotify-tools/default.nix:18:5:

       |
    18 |     license = licenses.gpl2;
       |     ^
    

@risicle
Copy link
Contributor

risicle commented Apr 18, 2021

nixpkgs-review happy, nixos x86_64. nixosTests dovecot, bittorrent, transmission successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants