Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wcslib: 7.5 -> 7.6 #119504

Merged
merged 4 commits into from Apr 15, 2021
Merged

wcslib: 7.5 -> 7.6 #119504

merged 4 commits into from Apr 15, 2021

Conversation

hjones2199
Copy link
Member

@hjones2199 hjones2199 commented Apr 15, 2021

Motivation for this change

Receive bugfixes from upstream

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hjones2199
Copy link
Member Author

Result of nixpkgs-review pr 119504 run on x86_64-linux 1

4 packages built:
  • kstars
  • siril
  • stellarsolver
  • wcslib

@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 15, 2021

Result of nixpkgs-review pr 119504 at 73551c28 run on x86_64-linux 1

4 packages built successfully:
  • kstars
  • siril
  • stellarsolver
  • wcslib
3 suggestions:
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '2775' doesn't match anything in file 'C/GNUmakefile'
    Near pkgs/development/libraries/science/astronomy/wcslib/default.nix:23:0:

       |
    23 |     description = "World Coordinate System library for astronomy";
       | ^
    
  • warning: build-tools-in-build-inputs

    flex is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

    Near pkgs/development/libraries/science/astronomy/wcslib/default.nix:12:3:

       |
    12 |   buildInputs = [ flex ];
       |   ^
    
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '2775' doesn't match anything in file 'GNUmakefile'
    Near pkgs/development/libraries/science/astronomy/wcslib/default.nix:23:0:

       |
    23 |     description = "World Coordinate System library for astronomy";
       | ^
    

Result of nixpkgs-review pr 119504 at 73551c28 run on aarch64-linux 1

1 package marked as broken and skipped:
  • kstars
1 package built successfully:
  • wcslib

@SuperSandro2000 SuperSandro2000 merged commit 35c8995 into NixOS:master Apr 15, 2021
@hjones2199 hjones2199 deleted the wcs76 branch April 16, 2021 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants