Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mailspring: 1.8.0 -> 1.9.0 #119515

Merged
merged 1 commit into from Apr 16, 2021
Merged

mailspring: 1.8.0 -> 1.9.0 #119515

merged 1 commit into from Apr 16, 2021

Conversation

doronbehar
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from toschmidt April 15, 2021 06:19
@doronbehar doronbehar force-pushed the pkg/mailspring/update branch 2 times, most recently from 8ccd31a to 2242595 Compare April 15, 2021 06:31
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 119515 at 2242595a run on x86_64-linux 1

1 package built successfully:
  • mailspring
1 suggestion:
  • warning: stale-substitute

    Stale substituteInPlace detected.
    substituteStream(): WARNING: pattern '/usr/bin' doesn't match anything in file '/nix/store/p4vdvjrxmm4wrxp8fsg8b6hzb8ca9526-mailspring-1.9.0/share/applications/Mailspring.desktop'
    Near pkgs/applications/networking/mailreaders/mailspring/default.nix:81:0:

       |
81 |     description = "A beautiful, fast and maintained fork of Nylas Mail by one of the original authors";
   | ^

@doronbehar
mailspring: 1.8.0 -> 1.9.0
ebf3d44 
- Remove now unneeded override for gtk3.
- Add pre and post hooks for explicit phases.
- Add doronbehar as maintainer.
- Update license, see:
https://community.getmailspring.com/t/a-free-open-source-future-for-mailspring/484
@SuperSandro2000 SuperSandro2000 merged commit 79e5c78 into NixOS:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@toschmidt toschmidt Awaiting requested review from toschmidt

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @r-rmcgibbo @SuperSandro2000