Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mujs: 1.0.9 -> 1.1.1 #119521

Merged
merged 1 commit into from Apr 15, 2021
Merged

mujs: 1.0.9 -> 1.1.1 #119521

merged 1 commit into from Apr 15, 2021

Conversation

LeSuisse
Copy link
Contributor

Motivation for this change

Version update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

23 packages built:
  • anki
  • ankisyncd
  • celluloid (gnome-mpv)
  • curseradio
  • hydrus
  • jellyfin-media-player
  • jellyfin-mpv-shim
  • jftui
  • minitube
  • mnemosyne
  • mpc-qt
  • mpv (mpv-with-scripts)
  • mpv-unwrapped
  • mpvScripts.mpris
  • mujs
  • plex-media-player
  • plex-mpv-shim
  • python38Packages.mpv
  • python39Packages.mpv
  • qimgv
  • somafm-cli
  • sublime-music
  • ytfzf

@ofborg ofborg bot requested a review from pSub April 15, 2021 08:45
@r-rmcgibbo
Copy link

r-rmcgibbo commented Apr 15, 2021 •
edited

Result of nixpkgs-review pr 119521 at 54ac23c run on aarch64-linux 1

1 package skipped due to time constraints:
  • plex-mpv-shim
18 packages built successfully:
  • anki
  • ankisyncd
  • celluloid
  • curseradio
  • hydrus
  • jellyfin-mpv-shim
  • jftui
  • minitube
  • mnemosyne
  • mpc-qt
  • mpv-unwrapped
  • mpvScripts.mpris
  • mujs
  • python38Packages.mpv
  • python39Packages.mpv
  • qimgv
  • somafm-cli
  • sublime-music

Result of nixpkgs-review pr 119521 at 54ac23c run on x86_64-linux 1

2 packages skipped due to time constraints:
  • plex-media-player
  • plex-mpv-shim
21 packages built successfully:
  • anki
  • ankisyncd
  • celluloid
  • curseradio
  • hydrus
  • jellyfin-media-player
  • jellyfin-mpv-shim
  • jftui
  • minitube
  • mnemosyne
  • mpc-qt
  • mpv
  • mpv-unwrapped
  • mpvScripts.mpris
  • mujs
  • python38Packages.mpv
  • python39Packages.mpv
  • qimgv
  • somafm-cli
  • sublime-music
  • ytfzf

SuperSandro2000
SuperSandro2000 approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@bachp bachp merged commit 9767875 into NixOS:master Apr 15, 2021
@LeSuisse LeSuisse deleted the mujs-1.1.1 branch April 16, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LeSuisse @r-rmcgibbo @SuperSandro2000 @bachp