Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waybar: 0.9.5 -> 0.9.7 #119561

Merged
merged 1 commit into from Apr 16, 2021
Merged

waybar: 0.9.5 -> 0.9.7 #119561

merged 1 commit into from Apr 16, 2021

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented Apr 15, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 119561 at df4e7e68 run on x86_64-linux 1

1 package built successfully:
  • waybar
2 suggestions:
  • warning: meson-cmake

    Meson uses CMake as a fallback dependency resolution method and it likely is not necessary here. The message about cmake not being found is purely informational.

    Near pkgs/applications/misc/waybar/default.nix:40:3:

       |
    40 |   nativeBuildInputs = [
       |   ^
    
  • warning: unused-argument

    Unused argument: fetchpatch.
    Near pkgs/applications/misc/waybar/default.nix:4:3:

      |
    4 | , fetchpatch
      |   ^
    

Copy link
Member

@minijackson minijackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiles and runs fine, thanks!


Result of nix-review pr 119561 1

1 package were built:
  • waybar

Copy link
Contributor

@Technical27 Technical27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this change for a bit, seems to work fine.

@lovesegfault lovesegfault merged commit 2461d45 into NixOS:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants